Skip to content

Make is_stdout work when sys.stdout does not have a fd#50328

Merged
potiuk merged 2 commits intoapache:mainfrom
quentin-sommer:main
May 22, 2025
Merged

Make is_stdout work when sys.stdout does not have a fd#50328
potiuk merged 2 commits intoapache:mainfrom
quentin-sommer:main

Conversation

@quentin-sommer
Copy link
Contributor

@quentin-sommer quentin-sommer commented May 8, 2025 •
edited
Loading

closes #50240

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented May 8, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@quentin-sommer quentin-sommer marked this pull request as ready for review May 8, 2025 16:56
@quentin-sommer quentin-sommer mentioned this pull request May 8, 2025
Closed
2 tasks
@potiuk potiuk added this to the Airflow 3.0.2 milestone May 12, 2025
@quentin-sommer
Copy link
Contributor Author

quentin-sommer commented May 20, 2025

@potiuk and/or @gyli how do we move this forward? I didn't find details on the PR merge process in the contribution doc

@potiuk
Copy link
Member

potiuk commented May 22, 2025

Rebased last one time to make sure it works.

@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label May 22, 2025
@potiuk potiuk merged commit e033afa into apache:main May 22, 2025
52 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented May 22, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions bot pushed a commit that referenced this pull request May 22, 2025
@quentin-sommer @potiuk
[v3-0-test] Make is_stdout work when sys.stdout does not have a fd (#…
c7d71e9 
…50328)

(cherry picked from commit e033afa)

Co-authored-by: Quentin Sommer <quentin-sommer@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions
Copy link

github-actions bot commented May 22, 2025

Backport successfully created: v3-0-test

Status Branch Result
✅ v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 22, 2025
@quentin-sommer @potiuk
[v3-0-test] Make is_stdout work when sys.stdout does not have a fd (a…
3e1bcf4 
…pache#50328)

(cherry picked from commit e033afa)

Co-authored-by: Quentin Sommer <quentin-sommer@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit that referenced this pull request May 22, 2025
@github-actions @quentin-sommer @potiuk
[v3-0-test] Make is_stdout work when sys.stdout does not have a fd (#…
71c14b6 
…50328) (#50949)

(cherry picked from commit e033afa)

Co-authored-by: Quentin Sommer <quentin-sommer@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@quentin-sommer
Copy link
Contributor Author

quentin-sommer commented May 22, 2025

thank you!

dadonnelly316 pushed a commit to dadonnelly316/airflow that referenced this pull request May 26, 2025
@quentin-sommer @potiuk @dadonnelly316
Make is_stdout work when sys.stdout does not have a fd (apache#50328)
3a4bb81 
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
@github-actions @quentin-sommer
@potiuk @kaxil
[v3-0-test] Make is_stdout work when sys.stdout does not have a fd (#…
4d23d5b 
…50328) (#50949)

(cherry picked from commit e033afa)

Co-authored-by: Quentin Sommer <quentin-sommer@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
@quentin-sommer @potiuk @sanederchik
Make is_stdout work when sys.stdout does not have a fd (apache#50328)
f8cfb24 
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

Assignees

No one assigned

Labels

area:CLI backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

connections_export CLI can fail when stdout doesn't have a fileno

2 participants

@quentin-sommer @potiuk